Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2769893002: Make :embedded_observatory_archive compilable on Win for Flutter (Closed)

Created:
3 years, 9 months ago by goderbauer
Modified:
3 years, 9 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make :embedded_observatory_archive compilable on Win for Flutter BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/e246034fca7cdbe76a78548a630a6d89e72a3008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/observatory/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
Cutch
lgtm
3 years, 9 months ago (2017-03-23 17:17:43 UTC) #5
Cutch
3 years, 9 months ago (2017-03-23 17:20:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e246034fca7cdbe76a78548a630a6d89e72a3008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698