Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2769873004: Fix status for canary (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix status for canary This particular test seems to have frequent canary only errors. Not sure there is a better way - e.g., alway ignore on Canary? TBR=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/4d983162d525a1715917fdda73c7733de4d6f1f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 4d983162d525a1715917fdda73c7733de4d6f1f6 (presubmit successful).
3 years, 9 months ago (2017-03-23 17:21:42 UTC) #2
Bob Nystrom
3 years, 9 months ago (2017-03-23 17:24:40 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698