Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index 6496a290e7e810cfa9ca87d1c8bc7f3cbe68e9d6..376291fe2b427b71a886471835343548b2c10bcb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -458,7 +458,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
objectPopoverHelper.dispose();
return false;
}
- var highlightRange = new Common.TextRange(lineNumber, startHighlight, lineNumber, endHighlight);
+ var highlightRange = new TextUtils.TextRange(lineNumber, startHighlight, lineNumber, endHighlight);
highlightDescriptor = this.textEditor.highlightRange(highlightRange, 'source-frame-eval-expression');
return true;
},
@@ -870,7 +870,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
new Set(decorations.map(decoration => decoration.bookmark).filter(bookmark => !!bookmark));
var lineEnd = this.textEditor.line(lineNumber).length;
var bookmarks = this.textEditor.bookmarks(
- new Common.TextRange(lineNumber, 0, lineNumber, lineEnd),
+ new TextUtils.TextRange(lineNumber, 0, lineNumber, lineEnd),
Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol);
for (var bookmark of bookmarks) {
if (!actualBookmarks.has(bookmark))
@@ -1003,7 +1003,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
this._willAddInlineDecorationsForTest();
this._breakpointManager
.possibleBreakpoints(
- this._debuggerSourceCode, new Common.TextRange(uiLocation.lineNumber, 0, uiLocation.lineNumber + 1, 0))
+ this._debuggerSourceCode, new TextUtils.TextRange(uiLocation.lineNumber, 0, uiLocation.lineNumber + 1, 0))
.then(addInlineDecorations.bind(this, uiLocation.lineNumber));
}
@@ -1301,7 +1301,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
if (this.textEditor.line(lineNumber).length >= maxLengthToCheck)
return Promise.resolve(/** @type {?Array<!Workspace.UILocation>} */ ([]));
return this._breakpointManager
- .possibleBreakpoints(this._debuggerSourceCode, new Common.TextRange(lineNumber, 0, lineNumber + 1, 0))
+ .possibleBreakpoints(this._debuggerSourceCode, new TextUtils.TextRange(lineNumber, 0, lineNumber + 1, 0))
.then(locations => locations.length ? locations : null);
}

Powered by Google App Engine
This is Rietveld 408576698