Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
index 38935d669c89e796268ca4a98927ec5a17c70134..e867d9363cb7f0e743bda161050d9a56747fe543 100644
--- a/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
@@ -43,7 +43,7 @@ SourceFrame.UISourceCodeFrame = class extends SourceFrame.SourceFrame {
/** @type {?UI.AutocompleteConfig} */
- this._autocompleteConfig = {isWordChar: Common.TextUtils.isWordChar};
+ this._autocompleteConfig = {isWordChar: TextUtils.TextUtils.isWordChar};
Common.moduleSetting('textEditorAutocompletion').addChangeListener(this._updateAutocomplete, this);
this._updateAutocomplete();
@@ -188,8 +188,8 @@ SourceFrame.UISourceCodeFrame = class extends SourceFrame.SourceFrame {
/**
* @override
- * @param {!Common.TextRange} oldRange
- * @param {!Common.TextRange} newRange
+ * @param {!TextUtils.TextRange} oldRange
+ * @param {!TextUtils.TextRange} newRange
*/
onTextChanged(oldRange, newRange) {
super.onTextChanged(oldRange, newRange);
@@ -580,7 +580,7 @@ SourceFrame.UISourceCodeFrame.RowMessageBucket = class {
lineNumber = Math.min(lineNumber, this.textEditor.linesCount - 1);
var lineText = this.textEditor.line(lineNumber);
columnNumber = Math.min(columnNumber, lineText.length);
- var lineIndent = Common.TextUtils.lineIndent(lineText).length;
+ var lineIndent = TextUtils.TextUtils.lineIndent(lineText).length;
if (this._hasDecoration)
this.textEditor.removeDecoration(this._decoration, lineNumber);
this._hasDecoration = true;

Powered by Google App Engine
This is Rietveld 408576698