third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js - Issue 2769843003: DevTools: split text_utils out of common module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)

Patch Set: rebaseline Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshotLoader.js ('k') | third_party/WebKit/Source/devtools/front_end/inline_editor/ColorSwatch.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js b/third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js

index 66ef9e3b5ea659b87cc7d7e62e2460ef1e453d70..12ef0312fd3776c59c5da9aaba70388eb75dcfc8 100644

--- a/third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowModel.js

@@ -43,7 +43,7 @@ InlineEditor.CSSShadowModel = class {

static _parseShadow(text, isBoxShadow) {

var shadowTexts = [];

// Split by commas that aren't inside of color values to get the individual shadow values.

- var splits = Common.TextUtils.splitStringByRegexes(text, [Common.Color.Regex, /,/g]);

+ var splits = TextUtils.TextUtils.splitStringByRegexes(text, [Common.Color.Regex, /,/g]);

var currentIndex = 0;

for (var i = 0; i < splits.length; i++) {

if (splits[i].regexIndex === 1) {

@@ -60,7 +60,7 @@ InlineEditor.CSSShadowModel = class {

shadow._format = [];

var nextPartAllowed = true;

var regexes = [/inset/gi, Common.Color.Regex, InlineEditor.CSSLength.Regex];

- var results = Common.TextUtils.splitStringByRegexes(shadowTexts[i], regexes);

+ var results = TextUtils.TextUtils.splitStringByRegexes(shadowTexts[i], regexes);

for (var j = 0; j < results.length; j++) {

var result = results[j];

if (result.regexIndex === -1) {