Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
index b4a5cf47562ff9162fd92ab33c5901121aa9b4e8..a7eb7f9ecb6135d47d4ce7e24e301e7e99af1744 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
@@ -64,7 +64,7 @@ Console.ConsolePrompt = class extends UI.Widget {
moveCaretToEndOfPrompt() {
if (this._editor)
- this._editor.setSelection(Common.TextRange.createFromLocation(Infinity, Infinity));
+ this._editor.setSelection(TextUtils.TextRange.createFromLocation(Infinity, Infinity));
}
/**
@@ -134,7 +134,7 @@ Console.ConsolePrompt = class extends UI.Widget {
this.setText(newText);
if (isPrevious)
- this._editor.setSelection(Common.TextRange.createFromLocation(0, Infinity));
+ this._editor.setSelection(TextUtils.TextRange.createFromLocation(0, Infinity));
else
this.moveCaretToEndOfPrompt();
this.setMinimumSize(0, this._editor.widget().element.offsetHeight);
@@ -238,12 +238,12 @@ Console.ConsolePrompt = class extends UI.Widget {
/**
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {?Common.TextRange}
+ * @return {?TextUtils.TextRange}
*/
_substituteRange(lineNumber, columnNumber) {
var token = this._editor.tokenAtTextPosition(lineNumber, columnNumber);
if (token && token.type === 'js-string')
- return new Common.TextRange(lineNumber, token.startColumn, lineNumber, columnNumber);
+ return new TextUtils.TextRange(lineNumber, token.startColumn, lineNumber, columnNumber);
var lineText = this._editor.line(lineNumber);
var index;
@@ -251,18 +251,18 @@ Console.ConsolePrompt = class extends UI.Widget {
if (' =:[({;,!+-*/&|^<>.\t\r\n'.indexOf(lineText.charAt(index)) !== -1)
break;
}
- return new Common.TextRange(lineNumber, index + 1, lineNumber, columnNumber);
+ return new TextUtils.TextRange(lineNumber, index + 1, lineNumber, columnNumber);
}
/**
- * @param {!Common.TextRange} queryRange
- * @param {!Common.TextRange} substituteRange
+ * @param {!TextUtils.TextRange} queryRange
+ * @param {!TextUtils.TextRange} substituteRange
* @param {boolean=} force
* @return {!Promise<!UI.SuggestBox.Suggestions>}
*/
_wordsWithQuery(queryRange, substituteRange, force) {
var query = this._editor.text(queryRange);
- var before = this._editor.text(new Common.TextRange(0, 0, queryRange.startLine, queryRange.startColumn));
+ var before = this._editor.text(new TextUtils.TextRange(0, 0, queryRange.startLine, queryRange.startColumn));
var historyWords = this._historyCompletions(query, force);
var token = this._editor.tokenAtTextPosition(substituteRange.startLine, substituteRange.startColumn);
if (token) {

Powered by Google App Engine
This is Rietveld 408576698