Issue 2769833002: mash: Make OverflowButtonInkDropTest.TouchContextMenu early out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2769833002: mash: Make OverflowButtonInkDropTest.TouchContextMenu early out (Closed)

Created:
3 years, 9 months ago by flackr

Modified:
3 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mash: Make OverflowButtonInkDropTest.TouchContextMenu early out BUG=695751, 704176

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ash/shelf/shelf_view_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

flackr

This adds a similar early out to OverflowButtonInkDropTest.TouchContextMenu as the one added to OverflowButtonActiveInkDropTest.TouchContextMenu as ...

3 years, 9 months ago (2017-03-22 20:46:32 UTC) #2

sky

On 2017/03/22 20:46:32, flackr wrote: > This adds a similar early out to OverflowButtonInkDropTest.TouchContextMenu as ...

3 years, 9 months ago (2017-03-22 22:24:11 UTC) #3

flackr

3 years, 9 months ago (2017-03-23 13:52:58 UTC) #4

On 2017/03/22 22:24:11, sky wrote:
> On 2017/03/22 20:46:32, flackr wrote:
> > This adds a similar early out to OverflowButtonInkDropTest.TouchContextMenu
as
> > the one added to OverflowButtonActiveInkDropTest.TouchContextMenu as it is
> flaky
> > as well. PTAL, thanks.
> 
> I think I have the fix for all this here:
> https://codereview.chromium.org/2772513003/

Okay, closing.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages