Fix --disable-fast-text-autosizing.

Fix --disable-fast-text-autosizing.

This has been broken since https://src.chromium.org/viewvc/blink?revision=172846&view=revision landed.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269623

[pdr., 2014-05-09 18:43:57]

On 2014/05/09 18:21:48, skobes wrote:

LGTM

[skobes, 2014-05-09 18:51:46]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-05-09 18:52:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/276983002/1

[commit-bot: I haz the power, 2014-05-09 21:12:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-09 21:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:17:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[skobes, 2014-05-09 21:33:56]

+piman for content/OWNERS

[piman, 2014-05-09 21:55:39]

https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
File content/child/runtime_features.cc (left):

https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
content/child/runtime_features.cc:138: if
(command_line.HasSwitch(switches::kEnableFastTextAutosizing)
Should we remove kEnableFastTextAutosizing altogether then?

[skobes, 2014-05-09 22:26:20]

On 2014/05/09 21:55:39, piman wrote:
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> File content/child/runtime_features.cc (left):
> 
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> content/child/runtime_features.cc:138: if
> (command_line.HasSwitch(switches::kEnableFastTextAutosizing)
> Should we remove kEnableFastTextAutosizing altogether then?

Actually we should probably keep it around in case we end up turning the default
off again.

[piman, 2014-05-09 22:41:53]

On 2014/05/09 22:26:20, skobes wrote:
> On 2014/05/09 21:55:39, piman wrote:
> >
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> > File content/child/runtime_features.cc (left):
> > 
> >
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> > content/child/runtime_features.cc:138: if
> > (command_line.HasSwitch(switches::kEnableFastTextAutosizing)
> > Should we remove kEnableFastTextAutosizing altogether then?
> 
> Actually we should probably keep it around in case we end up turning the
default
> off again.

Then we can re-introduce?

Right now the flag does nothing.

[skobes, 2014-05-09 22:44:12]

On 2014/05/09 22:41:53, piman wrote:
> On 2014/05/09 22:26:20, skobes wrote:
> > On 2014/05/09 21:55:39, piman wrote:
> > >
> >
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> > > File content/child/runtime_features.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/276983002/diff/1/content/child/runtime_featur...
> > > content/child/runtime_features.cc:138: if
> > > (command_line.HasSwitch(switches::kEnableFastTextAutosizing)
> > > Should we remove kEnableFastTextAutosizing altogether then?
> > 
> > Actually we should probably keep it around in case we end up turning the
> default
> > off again.
> 
> Then we can re-introduce?
> 
> Right now the flag does nothing.

By reading both flags in runtime_features.cc we avoid the need to update the
file again if we change the default.  (We probably should have done it this way
in the first place, which would have avoided the current problem.)

[piman, 2014-05-09 22:53:27]

Oh, ok, I misread the patch.
LGTM then.

[skobes, 2014-05-09 23:00:22]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:01:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skobes@chromium.org/276983002/20001

[commit-bot: I haz the power, 2014-05-10 19:50:13]

Change committed as 269623