Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2769813005: Allow navigation from var when there is an inferred type (issue 29091) (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow navigation from var when there is an inferred type (issue 29091) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/61d5c85b48c688f7a1b42ab6cd3ebf6c1cd91530

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 3 chunks +49 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-22 23:57:56 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2769813005/diff/1/pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart File pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart (right): https://codereview.chromium.org/2769813005/diff/1/pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart#newcode317 pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart:317: Element element = variables[1].name?.bestType?.element; variables[i] https://codereview.chromium.org/2769813005/diff/1/pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart#newcode327 pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart:327: if ...
3 years, 9 months ago (2017-03-23 00:05:34 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-23 17:34:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61d5c85b48c688f7a1b42ab6cd3ebf6c1cd91530 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698