Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2769743004: Allow disabling libXML in Clang's CMake build (Closed)

Created:
3 years, 9 months ago by Derek Schuff
Modified:
3 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow disabling libXML in Clang's CMake build We used this before the Precise upgrade for the same purpose I'm reintroducing it; the sysroot we are building in lacks libXML but Clang's CMake build finds it on the host system. R=stichnot@google.com, bradnelson@chromium.org BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4394 Committed: e34aaa1fd835c13131bf82b16b768253e14e9247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M CMakeLists.txt View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Derek Schuff
3 years, 9 months ago (2017-03-23 22:19:33 UTC) #1
Derek Schuff
3 years, 9 months ago (2017-03-23 22:38:31 UTC) #3
stichnot1
lgtm
3 years, 9 months ago (2017-03-23 23:03:08 UTC) #5
Derek Schuff
3 years, 9 months ago (2017-03-23 23:06:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e34aaa1fd835c13131bf82b16b768253e14e9247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698