BrowserMediaPlayerManager manages MediaKeys objects.

media/base/android/media_source_player.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_source_player.h"
 
 #include <limits>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 356 matching lines @@
 }
 
 void MediaSourcePlayer::OnMediaCryptoReady() {
   DCHECK(!drm_bridge_->GetMediaCrypto().is_null());
   drm_bridge_->SetMediaCryptoReadyCB(base::Closure());
 
   if (playing_)
     StartInternal();
 }
 
-void MediaSourcePlayer::SetDrmBridge(MediaDrmBridge* drm_bridge) {
+void MediaSourcePlayer::SetCdm(MediaKeys* cdm) {
   // Currently we don't support DRM change during the middle of playback, even
   // if the player is paused.
   // TODO(qinmin): support DRM change after playback has started.
   // http://crbug.com/253792.
   if (GetCurrentTime() > base::TimeDelta()) {
     VLOG(0) << "Setting DRM bridge after playback has started. "
             << "This is not well supported!";
   }
 
-  drm_bridge_ = drm_bridge;
+  // Only MediaDrmBridge will be set on MediaSourcePlayer.

[ddorwin, 2014/05/13 00:59:38]

This seems strange. Why did we go to all that trouble to use MediaKeys then cast
back?

Should we have kept GetMediaBridge() in BrowserMediaPlayerManager?

[xhwang, 2014/05/14 16:42:06]

The purpose of this CL is that BrowserMediaPlayerManager can manage any CDMs,
e.g. a ChromeCast CDM. So I'd keep any platform specific class out of the
manager.

+  drm_bridge_ = static_cast<MediaDrmBridge*>(cdm);
 
   if (drm_bridge_->GetMediaCrypto().is_null()) {
     drm_bridge_->SetMediaCryptoReadyCB(base::Bind(
         &MediaSourcePlayer::OnMediaCryptoReady, weak_factory_.GetWeakPtr()));
     return;
   }
 
   if (playing_)
     StartInternal();
 }
@@ skipping 610 matching lines @@
 
 void MediaSourcePlayer::ClearPendingEvent(PendingEventFlags event) {
   DVLOG(1) << __FUNCTION__ << "(" << GetEventName(event) << ")";
   DCHECK_NE(event, NO_EVENT_PENDING);
   DCHECK(IsEventPending(event)) << GetEventName(event);
 
   pending_event_ &= ~event;
 }
 
 }  // namespace media