Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2769703002: Revert "Issue 28580. Relax instantiate to bounds." (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Issue 28580. Relax instantiate to bounds." This reverts commit ef527a9bdef02534817fcb2cada5b3d4cef34c97. Unfortunately I have to do this because there are problems with recursion and corresponding error reporting. I fell it is better to don't have the feature than to have it half done :-( R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2bf5caed4e1a11c63fc2b8541ca222e364a7093b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -290 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +0 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +21 lines, -88 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 6 chunks +17 lines, -27 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +29 lines, -131 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-22 16:07:22 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-22 16:15:59 UTC) #2
scheglov
3 years, 9 months ago (2017-03-22 16:17:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2bf5caed4e1a11c63fc2b8541ca222e364a7093b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698