Move Oddball/String to %Typearray%.prototype.fill fast path

src/elements.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/elements.h"
 
 #include "src/arguments.h"
 #include "src/conversions.h"
 #include "src/factory.h"
 #include "src/isolate-inl.h"
@@ skipping 2845 matching lines @@
     *nof_items = count;
     return Just(true);
   }
 
   static Object* FillImpl(Isolate* isolate, Handle<JSObject> receiver,
                           Handle<Object> obj_value, uint32_t start,
                           uint32_t end) {
     Handle<JSTypedArray> array = Handle<JSTypedArray>::cast(receiver);
     DCHECK(!array->WasNeutered());
 
-    if (!obj_value->IsNumber()) {
-      return FillNumberSlowPath(isolate, array, obj_value, start, end);
-    }
-
     ctype value = 0;
     if (obj_value->IsSmi()) {
       value = BackingStore::from_int(Smi::cast(*obj_value)->value());
+    } else if (obj_value->IsHeapNumber()) {

[caitp, 2017/03/22 13:11:42]

Oh nvm, I thought we had a fast path in CSA. This is fine

[Camillo Bruni, 2017/03/22 21:26:50]

Given that we now perform additional checks, let's avoid the additional implied
IsHeapObject() tests further down by casting obj_value:

if (obj_value->IsSmi()) {
...
} else {
  Handle<HeapObject> heap_obj_value = Handle<HeapObject>::cast(obj_value);
  if (heap_obj_value->IsHeapNumber()) { ... }
  else if (heap_obj_value->IsNull(isolate) { .. }
  ...

}

[rongjie, 2017/03/23 00:01:49]

Done.

+      value = BackingStore::from_double(HeapNumber::cast(*obj_value)->value());
+    } else if (obj_value->IsUndefined(isolate)) {
+      value =
+          BackingStore::from_double(std::numeric_limits<double>::quiet_NaN());
+    } else if (obj_value->IsNull(isolate)) {
+      value = static_cast<ctype>(+0.0);
+    } else if (obj_value->IsBoolean()) {
+      value = static_cast<ctype>(obj_value->IsTrue(isolate));
     } else {
-      DCHECK(obj_value->IsHeapNumber());
-      value = BackingStore::from_double(HeapNumber::cast(*obj_value)->value());
+      return FillNumberSlowPath(isolate, array, obj_value, start, end);
     }
 
     // Ensure indexes are within array bounds
     DCHECK_LE(0, start);
     DCHECK_LE(start, end);
     DCHECK_LE(end, array->length_value());
 
     DisallowHeapAllocation no_gc;
     BackingStore* elements = BackingStore::cast(receiver->elements());
     ctype* data = static_cast<ctype*>(elements->DataPtr());
@@ skipping 1090 matching lines @@
     insertion_index += len;
   }
 
   DCHECK_EQ(insertion_index, result_len);
   return result_array;
 }
 
 ElementsAccessor** ElementsAccessor::elements_accessors_ = NULL;
 }  // namespace internal
 }  // namespace v8