tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html - Issue 2769643002: Speed up the EQT metric computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

Issue 2769643002: Speed up the EQT metric computation. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tracing/tracing/metrics/system_health/expected_queueing_time_metric.html ('K') | « tracing/tracing/metrics/system_health/expected_queueing_time_metric.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

diff --git a/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html b/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

index a71475808ff48e8ba2e838b2e76da37a0bb88893..685979b90931ede4d696a3a38ca31f02f033f0a5 100644

--- a/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

+++ b/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html

@@ -276,9 +276,11 @@ tr.b.unittest.testSuite(function() {

mainThread.sliceGroup.createSubSlices();

});

let histograms = new tr.v.HistogramSet();

+ const rendererToInteractiveTimestamps =

+ tr.e.chrome.getInteractiveTimestamps(model);

let contribution = tr.metrics.sh.contributionToExpectedQueueingTime(

(event => event.title === 'V8.GCFinalizeMC'), 'v8:gc',

- histograms, model);

+ rendererToInteractiveTimestamps, histograms, model);

let interactiveEQT = contribution.interactive;

assert.strictEqual(0.025, interactiveEQT.average);

let totalEQT = contribution.total;