Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

Issue 2769533002: Clean up calls to ToSkPicture (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
index ea592959ec6e6dab80ceeb29bdce79ee0de97b0e..7329a4da7cecbcf8788bf5e1cdc4dd6523e718af 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
@@ -37,7 +37,7 @@ void DrawingDisplayItem::analyzeForGpuRasterization(
// numSlowPaths.
if (!m_record)
return;
- analyzer.analyzePicture(ToSkPicture(m_record.get()));
+ analyzer.analyzePicture(ToSkPicture(m_record).get());
}
#ifndef NDEBUG
@@ -53,8 +53,8 @@ void DrawingDisplayItem::dumpPropertiesAsDebugString(
}
#endif
-static bool recordsEqual(const PaintRecord* record1,
- const PaintRecord* record2) {
+static bool recordsEqual(sk_sp<const PaintRecord> record1,
+ sk_sp<const PaintRecord> record2) {
if (record1->approximateOpCount() != record2->approximateOpCount())
return false;
@@ -116,7 +116,7 @@ bool DrawingDisplayItem::equals(const DisplayItem& other) const {
if (!record || !otherRecord)
return false;
- if (recordsEqual(record.get(), otherRecord.get()))
+ if (recordsEqual(record, otherRecord))
return true;
// Sometimes the client may produce different records for the same visual
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698