Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4117)

Unified Diff: cc/paint/display_item_list.cc

Issue 2769533002: Clean up calls to ToSkPicture (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/paint/paint_canvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/paint/display_item_list.cc
diff --git a/cc/paint/display_item_list.cc b/cc/paint/display_item_list.cc
index 4745dcef193743a10c1df5882e773da4e853b026..830b3fbb15ffed9066378c28404c6e5b35aaf8d4 100644
--- a/cc/paint/display_item_list.cc
+++ b/cc/paint/display_item_list.cc
@@ -102,12 +102,7 @@ NOINLINE DISABLE_CFI_PERF void RasterItem(const DisplayItem& base_item,
// SkPicture always does a wrapping save/restore on the canvas, so it is
// not necessary here.
- if (callback) {
- item.picture->playback(canvas, callback);
- } else {
- // TODO(enne): switch this to playback once PaintRecord is real.
- canvas->drawPicture(ToSkPicture(item.picture.get()));
- }
+ item.picture->playback(canvas, callback);
break;
}
case DisplayItem::FLOAT_CLIP: {
@@ -407,7 +402,7 @@ DisplayItemList::CreateTracedValue(bool include_items) const {
state->EndArray();
std::string b64_picture;
- PictureDebugUtil::SerializeAsBase64(ToSkPicture(item.picture.get()),
+ PictureDebugUtil::SerializeAsBase64(ToSkPicture(item.picture).get(),
&b64_picture);
state->SetString("skp64", b64_picture);
state->EndDictionary();
« no previous file with comments | « no previous file | cc/paint/paint_canvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698