third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp - Issue 2769533002: Clean up calls to ToSkPicture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp

Issue 2769533002: Clean up calls to ToSkPicture (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/paint/display_item_list.cc ('K') | « cc/paint/skia_paint_canvas.cc ('k') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp » ('j') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp b/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp

index 5f1201319b5b70039a9f0cc86c6aebb5a808de55..7cac007c2aabc2eb4a7c0d83f3588d96e012402a 100644

--- a/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.cpp

@@ -23,7 +23,9 @@ void PaintGeneratedImage::draw(PaintCanvas* canvas,

canvas->scale(destRect.width() / srcRect.width(),

destRect.height() / srcRect.height());

canvas->translate(-srcRect.x(), -srcRect.y());

- canvas->drawPicture(m_record, nullptr, &flags);

+ SkRect bounds = m_record->cullRect();

+ canvas->saveLayer(&bounds, &flags);

enne (OOO) 2017/03/21 23:08:11 Tested this change via LayoutTests/csspaint.

+ canvas->drawPicture(m_record);

}

void PaintGeneratedImage::drawTile(GraphicsContext& context,