Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 276943002: Fix a lint issue with UsbMidiDeviceAndroid.java. (Closed)

Created:
6 years, 7 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a lint issue with UsbMidiDeviceAndroid.java. Currently, the lint warns at: Error: Call requires API level 18 (current min is 14): android.hardware.usb.UsbDeviceConnection#bulkTransfer [NewApi] So we need to add @TargetApi to suppress this lint error. BUG=327768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/UsbMidiDeviceAndroid.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 7 months ago (2014-05-09 16:05:48 UTC) #1
qinmin
On 2014/05/09 16:05:48, Sungmann Cho wrote: > Please take a look. Thanks! lgtm
6 years, 7 months ago (2014-05-09 16:33:58 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-09 16:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/276943002/1
6 years, 7 months ago (2014-05-09 16:43:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 21:21:16 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 04:49:06 UTC) #6
Message was sent while issue was closed.
Change committed as 269528

Powered by Google App Engine
This is Rietveld 408576698