Firefox overlay is seen opened even if Import Overlay is Cancelled.

chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

Index: chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
diff --git a/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js b/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
index 24c108ec339dca52a30964ea449631c0850590a3..10a13a4f65655c8ab0941952e6d37b4da48ca3f2 100644
--- a/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
+++ b/chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
@@ -56,6 +56,11 @@ cr.define('settings', function() {
      * Prompts the user to choose a bookmarks file to import bookmarks from.
      */
     importFromBookmarksFile: function() {},

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please leave a blank line after this one.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    /**
+    * Close the Dialog if it is Opened.

[Ilya Sherman, 2017/03/27 15:21:52]

nit: s/Dialog/dialog; s/Opened/opened.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    */

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please fix up the indentation of the asterisks in this comment.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    closeDialog: function() {},

[Ilya Sherman, 2017/03/27 15:21:52]

nit: This should probably be named "closeImportDialog", so that it's clearer
which dialog this refers to, when the event is handled on the JavaScript side.

[nikhil.sahni, 2017/03/28 11:22:00]

Done.

+

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please remove this blank line.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

   };
 
   /**
@@ -82,6 +87,11 @@ cr.define('settings', function() {
     importFromBookmarksFile: function() {
       chrome.send('importFromBookmarksFile');
     },
+
+    /** @override */
+    closeDialog: function() {
+      chrome.send('closeDialog');

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Likewise, this should be named 'closeImportDialog'.  (Actually, does this
close the *import lock* dialog?  If so, it should probably be named
'closeImportLockDialog'.)

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    },
   };
 
   return {