chrome/browser/resources/settings/people_page/import_data_dialog.html - Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/import_data_dialog.html

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Patch Set: Firefox overlay is seen opened even if Import Overlay is Cancelled. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/import_data_browser_proxy.js ('k') | chrome/browser/resources/settings/people_page/import_data_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/import_data_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/import_data_dialog.html b/chrome/browser/resources/settings/people_page/import_data_dialog.html

index c26c83bbcede88fc0056ad7eb45159d73dd6c706..2f27258369bea934564623cd46ee248aa0e77379 100644

--- a/chrome/browser/resources/settings/people_page/import_data_dialog.html

+++ b/chrome/browser/resources/settings/people_page/import_data_dialog.html

@@ -34,7 +34,8 @@

width: 100%;

}

</style>

- <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}" ignore-popstate>

+ <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"

+ on-close="closeDialog_" ignore-popstate>

Srirama 2017/03/24 09:33:03 nit: give indentation

nikhil.sahni 2017/03/24 13:26:06 Done.

<div class="title">$i18n{importTitle}</div>

<div hidden$="[[!hasImportStatus_(