Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3342)

Unified Diff: chrome/browser/ui/views/importer/import_lock_dialog_view.h

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.
Patch Set: Implemented Widget Observer and Addressed Review Comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/importer/import_lock_dialog_view.h
diff --git a/chrome/browser/ui/views/importer/import_lock_dialog_view.h b/chrome/browser/ui/views/importer/import_lock_dialog_view.h
index c69140a9c6a6691db284bbd791980c33cf77a3b9..a73958e0b08bc97acbb17502e751abd84847d0b3 100644
--- a/chrome/browser/ui/views/importer/import_lock_dialog_view.h
+++ b/chrome/browser/ui/views/importer/import_lock_dialog_view.h
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "ui/views/view.h"
+#include "ui/views/widget/widget_observer.h"
#include "ui/views/window/dialog_delegate.h"
namespace views {
@@ -18,10 +19,12 @@ class Label;
// ImportLockDialogView asks the user to shut down Firefox before starting the
// profile import.
-class ImportLockDialogView : public views::DialogDelegateView {
+class ImportLockDialogView : public views::DialogDelegateView,
+ public views::WidgetObserver {
public:
static void Show(gfx::NativeWindow parent,
const base::Callback<void(bool)>& callback);
+ static void Hide();
private:
explicit ImportLockDialogView(const base::Callback<void(bool)>& callback);
@@ -37,6 +40,9 @@ class ImportLockDialogView : public views::DialogDelegateView {
bool Accept() override;
bool Cancel() override;
+ // views::WidgetObserver overrides:
Ilya Sherman 2017/04/04 16:47:13 nit: Please follow the pattern used above, and sim
nikhil.sahni 2017/04/05 06:07:55 Done.
+ void OnWidgetDestroying(views::Widget* widget) override;
+
private:
views::Label* description_label_;

Powered by Google App Engine
This is Rietveld 408576698