chrome/browser/resources/settings/people_page/import_data_dialog.js - Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/import_data_dialog.js

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Patch Set: Incorportaed Review Comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/import_data_dialog.html ('k') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('j') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/import_data_dialog.js

diff --git a/chrome/browser/resources/settings/people_page/import_data_dialog.js b/chrome/browser/resources/settings/people_page/import_data_dialog.js

index d98afd2bcb240f63226b5bee2f75307b3bd98205..2dce8f4eb0fca295ae98bc587ae5bb7053d6eab1 100644

--- a/chrome/browser/resources/settings/people_page/import_data_dialog.js

+++ b/chrome/browser/resources/settings/people_page/import_data_dialog.js

@@ -129,6 +129,9 @@ Polymer({

/** @private */

closeDialog_: function() {

+ //It's possible for the user to close the import dialog while a sub-dialog is

+ //still showing. Make sure to close that sub-dialog as well.

Ilya Sherman 2017/03/30 22:14:32 nit: Please make sure there's a space following "/

nikhil.sahni 2017/03/31 15:21:25 Done.

+ this.browserProxy_.closeImportLockDialog();

this.$.dialog.close();