Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: chrome/browser/resources/settings/people_page/import_data_dialog.js

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.
Patch Set: Fixed the Review Comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-import-data-dialog' is a component for importing 6 * @fileoverview 'settings-import-data-dialog' is a component for importing
7 * bookmarks and other data from other sources. 7 * bookmarks and other data from other sources.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-import-data-dialog', 10 is: 'settings-import-data-dialog',
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 /** @private */ 122 /** @private */
123 onActionButtonTap_: function() { 123 onActionButtonTap_: function() {
124 if (this.isImportFromFileSelected_()) 124 if (this.isImportFromFileSelected_())
125 this.browserProxy_.importFromBookmarksFile(); 125 this.browserProxy_.importFromBookmarksFile();
126 else 126 else
127 this.browserProxy_.importData(this.$.browserSelect.selectedIndex); 127 this.browserProxy_.importData(this.$.browserSelect.selectedIndex);
128 }, 128 },
129 129
130 /** @private */ 130 /** @private */
131 closeDialog_: function() { 131 closeDialog_: function() {
132 this.browserProxy_.closeDialog();
Ilya Sherman 2017/03/27 15:21:52 This line is confusing: One dialog is already bein
nikhil.sahni 2017/03/28 11:22:00 Done.
132 this.$.dialog.close(); 133 this.$.dialog.close();
133 }, 134 },
134 135
135 /** 136 /**
136 * @return {boolean} Whether the import button should be disabled. 137 * @return {boolean} Whether the import button should be disabled.
137 * @private 138 * @private
138 */ 139 */
139 shouldDisableImport_: function() { 140 shouldDisableImport_: function() {
140 return this.hasImportStatus_(settings.ImportDataStatus.IN_PROGRESS) || 141 return this.hasImportStatus_(settings.ImportDataStatus.IN_PROGRESS) ||
141 this.noImportDataTypeSelected_; 142 this.noImportDataTypeSelected_;
142 }, 143 },
143 }); 144 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698