Firefox overlay is seen opened even if Import Overlay is Cancelled.

chrome/browser/resources/settings/people_page/import_data_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the the Import Data dialog to allow
  * users to import data (like bookmarks) from other web browsers.
  */
 cr.exportPath('settings');
 
@@ skipping 37 matching lines @@
     /**
      * Starts importing data for the specificed source browser profile. The C++
      * responds with the 'import-data-status-changed' WebUIListener event.
      * @param {number} sourceBrowserProfileIndex
      */
     importData: function(sourceBrowserProfileIndex) {},
 
     /**
      * Prompts the user to choose a bookmarks file to import bookmarks from.
      */
     importFromBookmarksFile: function() {},

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please leave a blank line after this one.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    /**
+    * Close the Dialog if it is Opened.

[Ilya Sherman, 2017/03/27 15:21:52]

nit: s/Dialog/dialog; s/Opened/opened.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    */

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please fix up the indentation of the asterisks in this comment.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    closeDialog: function() {},

[Ilya Sherman, 2017/03/27 15:21:52]

nit: This should probably be named "closeImportDialog", so that it's clearer
which dialog this refers to, when the event is handled on the JavaScript side.

[nikhil.sahni, 2017/03/28 11:22:00]

Done.

+

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Please remove this blank line.

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

   };
 
   /**
    * @constructor
    * @implements {settings.ImportDataBrowserProxy}
    */
   function ImportDataBrowserProxyImpl() {}
   // The singleton instance_ is replaced with a test version of this wrapper
   // during testing.
   cr.addSingletonGetter(ImportDataBrowserProxyImpl);
 
   ImportDataBrowserProxyImpl.prototype = {
     /** @override */
     initializeImportDialog: function() {
       return cr.sendWithPromise('initializeImportDialog');
     },
 
     /** @override */
     importData: function(sourceBrowserProfileIndex) {
       chrome.send('importData', [sourceBrowserProfileIndex]);
     },
 
     /** @override */
     importFromBookmarksFile: function() {
       chrome.send('importFromBookmarksFile');
     },
+
+    /** @override */
+    closeDialog: function() {
+      chrome.send('closeDialog');

[Ilya Sherman, 2017/03/27 15:21:52]

nit: Likewise, this should be named 'closeImportDialog'.  (Actually, does this
close the *import lock* dialog?  If so, it should probably be named
'closeImportLockDialog'.)

[nikhil.sahni, 2017/03/28 11:21:59]

Done.

+    },
   };
 
   return {
     ImportDataBrowserProxy: ImportDataBrowserProxy,
     ImportDataBrowserProxyImpl: ImportDataBrowserProxyImpl,
   };
 });