chrome/browser/importer/importer_lock_dialog.h - Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/importer/importer_lock_dialog.h

Issue 2769383002: Firefox overlay is seen opened even if Import Overlay is Cancelled.

Patch Set: Fixed the Review Comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/importer/external_process_importer_host.cc ('k') | chrome/browser/resources/settings/people_page/import_data_browser_proxy.js » ('j') | chrome/browser/resources/settings/people_page/import_data_browser_proxy.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_	5 #ifndef CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_

6 #define CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_	6 #define CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_

7	7

8 #include "base/callback_forward.h"	8 #include "base/callback_forward.h"

9 #include "ui/gfx/native_widget_types.h"	9 #include "ui/gfx/native_widget_types.h"

10	10

11 namespace importer {	11 namespace importer {

12	12

13 // This function is called by an ImporterHost, and presents the Firefox profile	13 // This function is called by an ImporterHost, and presents the Firefox profile

14 // warning dialog. After closing the dialog, the ImportHost receives a callback	14 // warning dialog. After closing the dialog, the ImportHost receives a callback

15 // with the message either to skip the import, or to continue the process.	15 // with the message either to skip the import, or to continue the process.

16 void ShowImportLockDialog(gfx::NativeWindow parent,	16 void ShowImportLockDialog(gfx::NativeWindow parent,

17 const base::Callback<void(bool)>& callback);	17 const base::Callback<void(bool)>& callback);

18	18 void HideImportLockDialog();
	Ilya Sherman 2017/03/27 15:21:52 Please add documentation for this function. Please add documentation for this function. Ilya Sherman 2017/03/27 15:21:52 nit: Please leave a blank line before and after th nit: Please leave a blank line before and after this function declaration. nikhil.sahni 2017/03/28 11:21:59 Done. Show quoted text On 2017/03/27 15:21:52, Ilya Sherman wrote: > Please add documentation for this function. Done. nikhil.sahni 2017/03/28 11:21:59 Done. Show quoted text On 2017/03/27 15:21:52, Ilya Sherman wrote: > Please add documentation for this function. Done.
19 } // namespace importer	19 } // namespace importer

20	20

21 #endif // CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_	21 #endif // CHROME_BROWSER_IMPORTER_IMPORTER_LOCK_DIALOG_H_

OLD	NEW