Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2769373002: Treat external protocols as ABORTED with PlzNavigate (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index b34eca2b8379e722f58289572ff7ca06bd150a76..ca487a74d5a18353dd5d50beeaae248f4660920d 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -164,6 +164,10 @@ NavigationHandleImpl::~NavigationHandleImpl() {
base::Bind(&NotifyAbandonedTransferNavigation, GetGlobalRequestID()));
}
+ if (!GetContentClient()->browser()->IsHandledURL(url_)) {
jam 2017/03/24 14:49:49 if this was handled by the navigation interceptor
wychen 2017/03/24 15:33:55 This is obviously the wrong place to inject the er
+ net_error_code_ = net::ERR_ABORTED;
+ }
+
if (!IsRendererDebugURL(url_))
GetDelegate()->DidFinishNavigation(this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698