third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp - Issue 2769353002: Only create sticky position constraints for constrained sticky position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)

Patch Set: Set dependent patch. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

diff --git a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

index 8706e09f2a5c079a2ddc0af2eb68557368136677..7c979414e03277b1cd2c664b73cb6207aaeff6d6 100644

--- a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

+++ b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

@@ -98,7 +98,7 @@ static void updateAuxiliaryObjectProperties(const LayoutObject& object,

PaintLayer* paintLayer = object.enclosingLayer();

paintLayer->updateAncestorOverflowLayer(context.ancestorOverflowPaintLayer);

- if (object.styleRef().position() == EPosition::kSticky) {

+ if (object.styleRef().hasStickyConstrainedPosition()) {

paintLayer->layoutObject().updateStickyPositionConstraints();

// Sticky position constraints and ancestor overflow scroller affect the