Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2769353002: Only create sticky position constraints for constrained sticky position. (Closed)
Patch Set: Set dependent patch. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
4 * reserved. 4 * reserved.
5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 // See crbug.com/663650 for more details." 1197 // See crbug.com/663650 for more details."
1198 if (transformStyle3D() == TransformStyle3DPreserve3D) { 1198 if (transformStyle3D() == TransformStyle3DPreserve3D) {
1199 setIsStackingContext(true); 1199 setIsStackingContext(true);
1200 return; 1200 return;
1201 } 1201 }
1202 1202
1203 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop || 1203 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop ||
1204 hasOpacity() || hasTransformRelatedProperty() || hasMask() || 1204 hasOpacity() || hasTransformRelatedProperty() || hasMask() ||
1205 clipPath() || boxReflect() || hasFilterInducingProperty() || 1205 clipPath() || boxReflect() || hasFilterInducingProperty() ||
1206 hasBackdropFilter() || hasBlendMode() || hasIsolation() || 1206 hasBackdropFilter() || hasBlendMode() || hasIsolation() ||
1207 hasViewportConstrainedPosition() || 1207 hasViewportConstrainedPosition() || position() == EPosition::kSticky ||
1208 hasPropertyThatCreatesStackingContext(willChangeProperties()) || 1208 hasPropertyThatCreatesStackingContext(willChangeProperties()) ||
1209 containsPaint()) { 1209 containsPaint()) {
1210 setIsStackingContext(true); 1210 setIsStackingContext(true);
1211 } 1211 }
1212 } 1212 }
1213 1213
1214 void ComputedStyle::addCallbackSelector(const String& selector) { 1214 void ComputedStyle::addCallbackSelector(const String& selector) {
1215 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector)) 1215 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector))
1216 m_rareNonInheritedData.access()->m_callbackSelectors.push_back(selector); 1216 m_rareNonInheritedData.access()->m_callbackSelectors.push_back(selector);
1217 } 1217 }
(...skipping 1280 matching lines...) Expand 10 before | Expand all | Expand 10 after
2498 if (value < 0) 2498 if (value < 0)
2499 fvalue -= 0.5f; 2499 fvalue -= 0.5f;
2500 else 2500 else
2501 fvalue += 0.5f; 2501 fvalue += 0.5f;
2502 } 2502 }
2503 2503
2504 return roundForImpreciseConversion<int>(fvalue / zoomFactor); 2504 return roundForImpreciseConversion<int>(fvalue / zoomFactor);
2505 } 2505 }
2506 2506
2507 } // namespace blink 2507 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698