[MD setting] tool tips on controlledBy site exceptions

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
- * Enumeration mapping all possible controlled-by values for exceptions to
- * icons.
- * @enum {string}
- */
-var iconControlledBy = {
-  'extension': 'cr:extension',
-  'HostedApp': 'cr:extension',
-  'platform_app': 'cr:extension',
-  'policy' : 'cr20:domain',
-};
-
-/**
  * @fileoverview
  * 'site-list' shows a list of Allowed and Blocked sites for a given
  * category.
  */
 Polymer({
 
   is: 'site-list',
 
   behaviors: [SiteSettingsBehavior, WebUIListenerBehavior],
 
@@ skipping 145 matching lines @@
     this.populateList_();
 
     // The Session permissions are only for cookies.
     if (this.categorySubtype == settings.PermissionValues.SESSION_ONLY) {
       this.$.category.hidden =
           this.category != settings.ContentSettingsTypes.COOKIES;
     }
   },
 
   /**
-   * Returns which icon, if any, should represent the fact that this exception
-   * is controlled.
-   * @param {!SiteException} item The item from the list we're computing the
-   *    icon for.
-   * @return {string} The icon to show (or blank, if none).
-   */
-  computeIconControlledBy_: function(item) {
-    if (this.allSites)
-      return '';
-    return iconControlledBy[item.source] || '';
-  },
-
-  /**
    * Whether there are any site exceptions added for this content setting.
    * @return {boolean}
    * @private
    */
   hasSites_: function() {
     return !!this.sites.length;
   },
 
   /**
-   * @param {string} source Where the setting came from.
+   * @param {string} enforcement Whether the exception is controlled.

[tommycli, 2017/03/27 16:02:07]

nit: you may be able to use the actual chrome.settingsPrivate.Enforcement type
here. 

Also the comment "Whether the..." kind of implies a boolean type variable...
while it's actually more like an enum.

[dschuyler, 2017/03/28 01:05:53]

Done.

    * @param {boolean} readOnlyList Whether the site exception list is read-only.
    * @return {boolean}
    * @private
    */
-  isResetButtonHidden_: function(source, readOnlyList) {
-    return this.isExceptionControlled_(source) || this.allSites ||
-        !readOnlyList;
+  isResetButtonHidden_: function(enforcement, readOnlyList) {
+    return enforcement == chrome.settingsPrivate.Enforcement.ENFORCED ||
+        this.allSites || !readOnlyList;
   },
 
   /**
-   * @param {string} source Where the setting came from.
+   * @param {string} enforcement Whether the exception is controlled.
    * @param {boolean} readOnlyList Whether the site exception list is read-only.
    * @return {boolean}
    * @private
    */
-  isActionMenuHidden_: function(source, readOnlyList) {
-    return this.isExceptionControlled_(source) || this.allSites || readOnlyList;
+  isActionMenuHidden_: function(enforcement, readOnlyList) {
+    return enforcement == chrome.settingsPrivate.Enforcement.ENFORCED ||
+        this.allSites || readOnlyList;
   },
 
   /**
    * A handler for the Add Site button.
    * @param {!Event} e
    * @private
    */
   onAddSiteTap_: function(e) {
     assert(!this.readOnlyList);
     e.preventDefault();
@@ skipping 23 matching lines @@
       this.browserProxy_.getExceptionList(this.category).then(
         function(exceptionList) {
           this.processExceptions_([exceptionList]);
           this.closeActionMenu_();
       }.bind(this));
     }
   },
 
   /**
    * Process the exception list returned from the native layer.
-   * @param {!Array<!Array<SiteException>>} data List of sites (exceptions) to
-   *     process.
+   * @param {!Array<!Array<RawSiteException>>} data List of sites (exceptions)
+   *     to process.
    * @private
    */
   processExceptions_: function(data) {
-    var sites = [];
-    for (var i = 0; i < data.length; ++i)
-      sites = this.appendSiteList_(sites, data[i]);
+    var sites = /** @type {!Array<RawSiteException>} */ ([]);
+    for (var i = 0; i < data.length; ++i) {
+      var exceptionList = data[i];
+      for (var k = 0; k < exceptionList.length; ++k) {
+        if (!this.allSites &&
+            (exceptionList[k].setting == settings.PermissionValues.DEFAULT ||
+             exceptionList[k].setting != this.categorySubtype)) {
+          continue;
+        }
+
+        sites.push(exceptionList[k]);
+      }
+    }
     this.sites = this.toSiteArray_(sites);
   },
 
   /**
    * Retrieves a list of all known sites (any category/setting).
    * @return {!Promise}
    * @private
    */
   getAllSitesList_: function() {
     var promiseList = [];
@@ skipping 10 matching lines @@
 
       promiseList.push(
           this.browserProxy_.getExceptionList(
               settings.ContentSettingsTypes[type]));
     }
 
     return Promise.all(promiseList);
   },
 
   /**
-   * Appends to |list| the sites for a given category and subtype.
-   * @param {!Array<SiteException>} sites The site list to add to.
-   * @param {!Array<SiteException>} exceptionList List of sites (exceptions) to
-   *     add.
-   * @return {!Array<SiteException>} The list of sites.
-   * @private
-   */
-  appendSiteList_: function(sites, exceptionList) {
-    for (var i = 0; i < exceptionList.length; ++i) {
-      if (!this.allSites) {
-        if (exceptionList[i].setting == settings.PermissionValues.DEFAULT)
-          continue;
-
-        if (exceptionList[i].setting != this.categorySubtype)
-          continue;
-      }
-
-      sites.push(exceptionList[i]);
-    }
-    return sites;
-  },
-
-  /**
    * Converts a list of exceptions received from the C++ handler to
    * full SiteException objects. If this site-list is used as an all sites
    * view, the list is sorted by site name, then protocol and port and de-duped
    * (by origin).
-   * @param {!Array<SiteException>} sites A list of sites to convert.
+   * @param {!Array<RawSiteException>} sites A list of sites to convert.
    * @return {!Array<SiteException>} A list of full SiteExceptions. Sorted and
    *    deduped if allSites is set.
    * @private
    */
   toSiteArray_: function(sites) {
     var self = this;
     if (this.allSites) {
       sites.sort(function(a, b) {
         var url1 = self.toUrl(a.origin);
         var url2 = self.toUrl(b.origin);
@@ skipping 177 matching lines @@
 
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     var actionMenu = /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]'));
     if (actionMenu.open)
       actionMenu.close();
   },
 });