[MD Extensions] Include the manifest code snippet in load errors

chrome/browser/resources/md_extensions/load_error.js

Index: chrome/browser/resources/md_extensions/load_error.js
diff --git a/chrome/browser/resources/md_extensions/load_error.js b/chrome/browser/resources/md_extensions/load_error.js
index 75b47ffa558815f0ae0f5e530b142becd8714191..ff4b54ce11efcb66049299ec684d077fed2e5b60 100644
--- a/chrome/browser/resources/md_extensions/load_error.js
+++ b/chrome/browser/resources/md_extensions/load_error.js
@@ -19,11 +19,14 @@ cr.define('extensions', function() {
       /** @type {extensions.LoadErrorDelegate} */
       delegate: Object,
 
-      error: String,
-
-      filePath: String,
+      /** @type {chrome.developerPrivate.LoadError} */
+      loadError: Object,
     },
 
+    observers: [
+      'observeLoadErrorChanges_(loadError)',
+    ],
+
     show: function() {
       this.$$('dialog').showModal();
     },
@@ -37,6 +40,24 @@ cr.define('extensions', function() {
       this.delegate.retryLoadUnpacked();
       this.close();
     },
+
+    /** @private */
+    observeLoadErrorChanges_: function() {
+      assert(this.loadError);
+      var source = this.loadError.source;
+      // CodeSection expects a RequestFileSourceResponse, rather than an
+      // ErrorFileSource. Massage into place.
+      // TODO(devlin): Make RequestFileSourceResponse use ErrorFileSource.
+      var codeSectionProperties = {

[michaelpg, 2017/03/24 02:59:01]

does closure let you "cast" this to @type !RequestFileSourceResponse? (so it can
yell at us if we massage this incorrectly)

[Devlin, 2017/03/24 16:03:08]

Yep, done.

+        beforeHighlight: source ? source.beforeHighlight : '',
+        highlight: source ? source.highlight : '',
+        afterHighlight: source ? source.afterHighlight : '',
+        title: '',
+        message: this.loadError.error,
+      };
+
+      this.$.code.set('code', codeSectionProperties);
+    },
   });
 
   return {LoadError: LoadError,