Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2748)

Unified Diff: chrome/browser/resources/md_extensions/service.js

Issue 2769293002: [MD Extensions] Include the manifest code snippet in load errors (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/service.js
diff --git a/chrome/browser/resources/md_extensions/service.js b/chrome/browser/resources/md_extensions/service.js
index c3f9d5272ca8b97bfd8a82ae4e2d984130316fe8..eec87f9e285c7677ce794d98a834d0922a9fa73d 100644
--- a/chrome/browser/resources/md_extensions/service.js
+++ b/chrome/browser/resources/md_extensions/service.js
@@ -253,8 +253,18 @@ cr.define('extensions', function() {
/** @override */
loadUnpacked: function() {
- chrome.developerPrivate.loadUnpacked({failQuietly: true}, () => {
- // TODO(devlin): Show the load error dialog if something went wrong.
+ chrome.developerPrivate.loadUnpacked(
+ {failQuietly: true, populateError: true},
+ (loadError) => {
+ if (chrome.runtime.lastError &&
+ chrome.runtime.lastError.message !=
+ 'File selection was canceled.') {
+ throw new Error(chrome.runtime.lastError.message);
+ }
+ if (loadError) {
+ this.manager_.loadError.set('loadError', loadError);
+ this.manager_.loadError.show();
+ }
});
},
« no previous file with comments | « chrome/browser/resources/md_extensions/load_error.js ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698