[MD Extensions] Include the manifest code snippet in load errors

chrome/browser/resources/md_extensions/compiled_resources2.gyp

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'targets': [
     {
       'target_name': 'animation_helper',
       'dependencies': [
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
@@ skipping 99 matching lines @@
         '<(EXTERNS_GYP):developer_private',
         'animation_helper',
       ],
       'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
     },
     {
       'target_name': 'load_error',
       'dependencies': [
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
+        '<(EXTERNS_GYP):developer_private',
+        'code_section',

[michaelpg, 2017/03/24 02:59:01]

not actually used, I think?

[Devlin, 2017/03/24 16:03:08]

It's used in spirit? ;)

// load_error.js
this.$.code.set('code', codeSectionProperties);

// load_error.html
<extensions-code-section id="code"></extensions-code-section>

So, conceptually, we *are* using it - we're reaching into the object and setting
the 'code' property on it.  I don't think closure is quite smart enough to
realize that yet, and I didn't *really* want to do the ugly cast of
(/** @type {extensions.CodeSection} */(this.$.code)).set(), since I also don't
think closure validates set() calls in any way.

WDYT in this situation?  Include it for completeness, or omit it because it
doesn't technically matter?

[michaelpg, 2017/03/24 21:25:32]

Agreed, and that makes sense for HTML imports too. But Closure takes long enough
to run that I'd prefer keeping this small if possible.
No. Actually, Closure makes bad inferences here that can hide actual errors, but
we do use this.$.something everywhere anyway. Sometimes we cast, sometimes not.
Technically it does, but not in a very useful way; |value| is just {*}:
    @param {(string|Array<(string|number)>)} path
    @param {*} value
    @param {Object=} root

But! We only have to use set() for deep sub-properties, not top-level
properties.
I prefer omit unless you actually use it.

[Devlin, 2017/03/25 01:58:00]

Done.

       ],
       'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
     },
     {
       'target_name': 'manager',
       'dependencies': [
         '<(DEPTH)/ui/webui/resources/cr_elements/cr_drawer/compiled_resources2.gyp:cr_drawer',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:i18n_behavior',
@@ skipping 66 matching lines @@
       'target_name': 'toolbar',
       'dependencies': [
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:cr',
         '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:i18n_behavior',
       ],
       'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
     },
   ]
 }