Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 2769293002: [MD Extensions] Include the manifest code snippet in load errors (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extensions_ui.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 IDS_EXTENSIONS_ENABLE_ERROR_COLLECTION); 174 IDS_EXTENSIONS_ENABLE_ERROR_COLLECTION);
175 source->AddLocalizedString("itemCorruptInstall", 175 source->AddLocalizedString("itemCorruptInstall",
176 IDS_EXTENSIONS_CORRUPTED_EXTENSION); 176 IDS_EXTENSIONS_CORRUPTED_EXTENSION);
177 source->AddLocalizedString("itemRepair", IDS_EXTENSIONS_REPAIR_CORRUPTED); 177 source->AddLocalizedString("itemRepair", IDS_EXTENSIONS_REPAIR_CORRUPTED);
178 source->AddLocalizedString("itemReload", IDS_EXTENSIONS_RELOAD_TERMINATED); 178 source->AddLocalizedString("itemReload", IDS_EXTENSIONS_RELOAD_TERMINATED);
179 source->AddString( 179 source->AddString(
180 "itemSuspiciousInstall", 180 "itemSuspiciousInstall",
181 l10n_util::GetStringFUTF16( 181 l10n_util::GetStringFUTF16(
182 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE, 182 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE,
183 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE))); 183 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE)));
184 source->AddLocalizedString(
185 "loadErrorCouldNotLoadManifest",
186 IDS_MD_EXTENSIONS_LOAD_ERROR_COULD_NOT_LOAD_MANIFEST);
184 source->AddLocalizedString("loadErrorHeading", 187 source->AddLocalizedString("loadErrorHeading",
185 IDS_MD_EXTENSIONS_LOAD_ERROR_HEADING); 188 IDS_MD_EXTENSIONS_LOAD_ERROR_HEADING);
186 source->AddLocalizedString("loadErrorFileLabel", 189 source->AddLocalizedString("loadErrorFileLabel",
187 IDS_MD_EXTENSIONS_LOAD_ERROR_FILE_LABEL); 190 IDS_MD_EXTENSIONS_LOAD_ERROR_FILE_LABEL);
188 source->AddLocalizedString("loadErrorErrorLabel", 191 source->AddLocalizedString("loadErrorErrorLabel",
189 IDS_MD_EXTENSIONS_LOAD_ERROR_ERROR_LABEL); 192 IDS_MD_EXTENSIONS_LOAD_ERROR_ERROR_LABEL);
190 source->AddLocalizedString("loadErrorCancel", 193 source->AddLocalizedString("loadErrorCancel",
191 IDS_MD_EXTENSIONS_LOAD_ERROR_CANCEL); 194 IDS_MD_EXTENSIONS_LOAD_ERROR_CANCEL);
192 source->AddLocalizedString("loadErrorRetry", 195 source->AddLocalizedString("loadErrorRetry",
193 IDS_MD_EXTENSIONS_LOAD_ERROR_RETRY); 196 IDS_MD_EXTENSIONS_LOAD_ERROR_RETRY);
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 ExtensionsUI::~ExtensionsUI() {} 380 ExtensionsUI::~ExtensionsUI() {}
378 381
379 // static 382 // static
380 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes( 383 base::RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes(
381 ui::ScaleFactor scale_factor) { 384 ui::ScaleFactor scale_factor) {
382 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 385 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
383 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor); 386 return rb.LoadDataResourceBytesForScale(IDR_EXTENSIONS_FAVICON, scale_factor);
384 } 387 }
385 388
386 } // namespace extensions 389 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_extensions/service.js ('k') | chrome/test/data/webui/extensions/cr_extensions_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698