Issue 2769253002: change "deferred" keyword isPseudo --> isBuiltIn

Issue 2769253002: change "deferred" keyword isPseudo --> isBuiltIn (Closed)

Created:
3 years, 9 months ago by danrubel

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry, ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -57 lines)			Patch
M	pkg/front_end/lib/src/fasta/scanner/keyword.dart	View	1	4 chunks	+8 lines, -11 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/token.dart	View	1 2	2 chunks	+5 lines, -19 lines	0 comments	Download
M	pkg/front_end/test/scanner_roundtrip_test.dart	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	pkg/front_end/test/token_test.dart	View		3 chunks	+55 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

lgtm assuming this has been adequately tested :) (I would recommend running the full set ...

3 years, 9 months ago (2017-03-23 20:11:45 UTC) #3

ahe

lgtm I agree with Paul :-) Let me know if you need help with testing.

3 years, 9 months ago (2017-03-24 12:34:20 UTC) #4

danrubel

3 years, 9 months ago (2017-03-26 01:20:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
05300ea2dff0e5cc63ec4288dba623116cd2c9a8 (presubmit successful).