Issue 276903002: Remove credentials passing API version 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276903002: Remove credentials passing API version 1 (Closed)

Created:
6 years, 7 months ago by bartfab (slow)

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Polukhin, xiyuan

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove credentials passing API version 1 Remove API version 1 of the credentials passing API and rename version 2 to version 1. This renumbering is backwards-incompatible and would break any existing users of API version 1. However, the API is still under development and thee are no users yet. Thus, we should take the opportunity to remove the cruft of an obsolete experimental API version before we release anything to the public. BUG=367847 TEST=Updated browser test TBR=nkostylev Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269590

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -147 lines)			Patch
M	chrome/browser/chromeos/login/saml/saml_browsertest.cc	View	1 chunk	+3 lines, -20 lines	0 comments	Download
M	chrome/browser/resources/gaia_auth/main.js	View	4 chunks	+8 lines, -29 lines	0 comments	Download
A +	chrome/test/data/login/saml_api_login.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/test/data/login/saml_api_login_v1.html	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/test/data/login/saml_api_login_v2.html	View	1 chunk	+0 lines, -59 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

Hi Xiyuan, Could you take a look please? I would like to get this clean-up ...

6 years, 7 months ago (2014-05-09 13:10:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/276903002/1

6 years, 7 months ago (2014-05-09 15:40:46 UTC) #4

Message was sent while issue was closed.

Change committed as 269590

Expand Messages | Collapse Messages