Not able to set width using ColGroup when table-layout is fixed.

Source/core/rendering/FixedTableLayout.cpp

Index: Source/core/rendering/FixedTableLayout.cpp
diff --git a/Source/core/rendering/FixedTableLayout.cpp b/Source/core/rendering/FixedTableLayout.cpp
index 69cd24819aa51ae7aa28124254b48b730021ef75..5c1e47c668c70a05d64cf66d2d58a9d872102307 100644
--- a/Source/core/rendering/FixedTableLayout.cpp
+++ b/Source/core/rendering/FixedTableLayout.cpp
@@ -159,7 +159,12 @@ int FixedTableLayout::calcWidthArray()
             float eSpan = m_table->spanOfEffCol(currentColumn);
             // Only set if no col element has already set it.
             if (m_width[currentColumn].isAuto() && logicalWidth.type() != Auto) {
-                m_width[currentColumn] = logicalWidth;
+                // Some column do not have col width specified by colgroup so
+                // by default those column should set as auto.
+                if (span > 1)
+                    m_width[currentColumn].setValue(m_width[currentColumn].type(), logicalWidth.intValue());

[Julien - ping for review, 2013/10/22 21:11:41]

I don't understand how this line is correct: m_width[currentColumn].type() is
Auto if you are in this branch, setting a value in this case is just wrong.

If I am reading correctly, this line just ignore the logical width value.

[suchit.agrawal, 2013/10/23 13:41:06]

If column is auto then we need to keep it auto.
By assigning 'logicalWidth' to 'm_width[currentColumn]',
'm_width[currentColumn]' become fixed. So now we are assigning 'logicalWidth' to
'm_width[currentColumn]' but setting 'm_width[currentColumn]' as Auto.

[Julien - ping for review, 2013/10/23 17:04:52]

Again, you're explaining 'what' which can be inferred from the code. What I am
interested in is *why*.

Also what you are telling me is basically that we should ignore logicalWidth for
span > 1, we don't need this confusing line.

+                else
+                    m_width[currentColumn] = logicalWidth;
                 m_width[currentColumn] *= eSpan / span;
                 usedWidth += fixedBorderBoxLogicalWidth * eSpan / span;
             }