Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: content/browser/frame_host/frame_tree_node.cc

Issue 2768933004: Ensure that the PlzNavigate code path removes pending NavigationEntrys if the navigation is cancell… (Closed)
Patch Set: without PlzNavigate Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree_node.h" 5 #include "content/browser/frame_host/frame_tree_node.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 void FrameTreeNode::DidChangeLoadProgress(double load_progress) { 492 void FrameTreeNode::DidChangeLoadProgress(double load_progress) {
493 loading_progress_ = load_progress; 493 loading_progress_ = load_progress;
494 frame_tree_->UpdateLoadProgress(); 494 frame_tree_->UpdateLoadProgress();
495 } 495 }
496 496
497 bool FrameTreeNode::StopLoading() { 497 bool FrameTreeNode::StopLoading() {
498 if (IsBrowserSideNavigationEnabled()) { 498 if (IsBrowserSideNavigationEnabled()) {
499 if (navigation_request_) { 499 if (navigation_request_) {
500 navigation_request_->navigation_handle()->set_net_error_code( 500 navigation_request_->navigation_handle()->set_net_error_code(
501 net::ERR_ABORTED); 501 net::ERR_ABORTED);
502 navigator_->DiscardPendingEntryIfNeeded(
503 navigation_request_->navigation_handle());
502 } 504 }
503 ResetNavigationRequest(false); 505 ResetNavigationRequest(false);
504 } 506 }
505 507
506 // TODO(nasko): see if child frames should send IPCs in site-per-process 508 // TODO(nasko): see if child frames should send IPCs in site-per-process
507 // mode. 509 // mode.
508 if (!IsMainFrame()) 510 if (!IsMainFrame())
509 return true; 511 return true;
510 512
511 render_manager_.Stop(); 513 render_manager_.Stop();
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 } 560 }
559 return parent_->child_at(i + relative_offset); 561 return parent_->child_at(i + relative_offset);
560 } 562 }
561 } 563 }
562 564
563 NOTREACHED() << "FrameTreeNode not found in its parent's children."; 565 NOTREACHED() << "FrameTreeNode not found in its parent's children.";
564 return nullptr; 566 return nullptr;
565 } 567 }
566 568
567 } // namespace content 569 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698