Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2527)

Unified Diff: docs/sync/model_api.md

Issue 2768923005: [Sync] Adding missing DependsOn to *ProfileSyncServiceFactory. (Closed)
Patch Set: Added crbug. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: docs/sync/model_api.md
diff --git a/docs/sync/model_api.md b/docs/sync/model_api.md
index eebf34d8a09775f3130121fe39df17b1031a2350..67ff6e3c936c9e1af3144b8870e26a184e9034fa 100644
--- a/docs/sync/model_api.md
+++ b/docs/sync/model_api.md
@@ -261,6 +261,8 @@ be started again from scratch on the next client restart.
[`ProfileSyncComponentsFactoryImpl::RegisterDataTypes`][RegisterDataTypes].
* Tell sync how to access your `ModelTypeSyncBridge` in
[`ChromeSyncClient::GetSyncBridgeForModelType`][GetSyncBridge].
+* Add your KeyedService dependency to
+ [`ProfileSyncServiceFactory`][ProfileSyncServiceFactory].
* Add to the [start order list][kStartOrder].
* Add an field for encrypted data to [`NigoriSpecifics`][NigoriSpecifics].
* Add to two encrypted types translation functions in
@@ -279,6 +281,7 @@ be started again from scratch on the next client restart.
[ModelTypeController]: https://cs.chromium.org/chromium/src/components/sync/driver/model_type_controller.h
[RegisterDataTypes]: https://cs.chromium.org/search/?q="ProfileSyncComponentsFactoryImpl::RegisterDataTypes"
[GetSyncBridge]: https://cs.chromium.org/search/?q=GetSyncBridgeForModelType+file:chrome_sync_client.cc
+[ProfileSyncServiceFactory]: https://cs.chromium.org/search/?q=:ProfileSyncServiceFactory%5C(%5C)
[kStartOrder]: https://cs.chromium.org/search/?q="kStartOrder[]"
[NigoriSpecifics]: https://cs.chromium.org/chromium/src/components/sync/protocol/nigori_specifics.proto
[nigori_util]: https://cs.chromium.org/chromium/src/components/sync/syncable/nigori_util.cc

Powered by Google App Engine
This is Rietveld 408576698