Fix webview-accessible resource checks in AllowCrossRendererResourceLoadHelper

chrome/browser/apps/guest_view/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 #include <set>
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/files/file_util.h"
@@ skipping 3292 matching lines @@
       GetGuestViewManager()->GetLastGuestCreated();
   ASSERT_TRUE(embedder_contents);
   ASSERT_TRUE(web_view_contents);
 
   GURL embedder_url(embedder_contents->GetLastCommittedURL());
   GURL webview_url(embedder_url.GetOrigin().spec() + "assets/foo.html");
 
   EXPECT_EQ(webview_url, web_view_contents->GetLastCommittedURL());
 }
 
+// Tests that a WebView cannot load a webview-inaccessible resource. See
+// https://crbug.com/640072.
+IN_PROC_BROWSER_TEST_P(WebViewTest, LoadWebviewInaccessibleResource) {
+  TestHelper("testLoadWebviewInaccessibleResource",
+             "web_view/load_webview_accessible_resource", NEEDS_TEST_SERVER);
+
+  content::WebContents* embedder_contents = GetEmbedderWebContents();
+  content::WebContents* web_view_contents =
+      GetGuestViewManager()->GetLastGuestCreated();
+  ASSERT_TRUE(embedder_contents);
+  ASSERT_TRUE(web_view_contents);
+
+  // Check that the webview stays at the first page that it loaded (foo.html),
+  // and does not commit inaccessible.html.
+  GURL embedder_url(embedder_contents->GetLastCommittedURL());
+  GURL foo_url(embedder_url.GetOrigin().spec() + "assets/foo.html");
+
+  EXPECT_EQ(foo_url, web_view_contents->GetLastCommittedURL());
+}
+
 // Tests that a webview inside an iframe can load and that it is destroyed when
 // the iframe is detached.
 IN_PROC_BROWSER_TEST_P(WebViewTest, LoadWebviewInsideIframe) {
   TestHelper("testLoadWebviewInsideIframe",
              "web_view/load_webview_inside_iframe", NEEDS_TEST_SERVER);
 
   // WebContents is leaked when using BrowserPlugin.
   if (!base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames))
     return;
 
@@ skipping 657 matching lines @@
                        ClosingChromeSignInShouldNotCrash) {
   GURL signin_url{"chrome://chrome-signin"};
 
   AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
   AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
   WaitForWebViewInDom();
 
   chrome::CloseTab(browser());
 }
 #endif