Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2768813002: PlzNavigate: don't stop all loaders when renderer-initiated nav fails
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index a351c4487319ec859f884da60d959242aca0a752..4cb0b45d808a05a8e4cc4d10021c9b519cd46c56 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -219,16 +219,18 @@ std::unique_ptr<NavigationRequest> NavigationRequest::CreateBrowserInitiated(
std::unique_ptr<NavigationRequest> navigation_request(new NavigationRequest(
frame_tree_node, common_params,
- BeginNavigationParams(entry.extra_headers(), net::LOAD_NORMAL,
- false, // has_user_gestures
- false, // skip_service_worker
- REQUEST_CONTEXT_TYPE_LOCATION,
- blink::WebMixedContentContextType::Blockable,
- // TODO(arthursonzogni): It can be true for form
- // resubmission when the user reloads the page. This
- // needs to be fixed.
- false, // is_form_submission
- initiator),
+ BeginNavigationParams(
+ entry.extra_headers(), net::LOAD_NORMAL,
+ false, // has_user_gestures
+ false, // skip_service_worker
+ REQUEST_CONTEXT_TYPE_LOCATION,
+ blink::WebMixedContentContextType::Blockable,
+ // TODO(arthursonzogni): It can be true for form
+ // resubmission when the user reloads the page. This
+ // needs to be fixed.
+ false, // is_form_submission
+ initiator,
+ kInvalidRenderNavigationId), // renderer_navigation_id
entry.ConstructRequestNavigationParams(
frame_entry, common_params.url, common_params.method,
is_history_navigation_in_new_child,

Powered by Google App Engine
This is Rietveld 408576698