Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2768803002: Update status for three flaky analyzer unit tests (Closed)

Created:
3 years, 9 months ago by Bill Hesse
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for three flaky analyzer unit tests BUG=https://github.com/dart-lang/sdk/issues/29133 R=brianwilkerson@google.com, kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/e0d65210256e7be80d44a46cdfebd90d842ceb6b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/pkg.status View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
Bill Hesse
3 years, 9 months ago (2017-03-22 13:56:57 UTC) #2
kustermann
LGTM https://codereview.chromium.org/2768803002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/2768803002/diff/1/pkg/pkg.status#newcode16 pkg/pkg.status:16: analyzer/tool/summary/check_test: Skip # Issue 29133 Please keep the ...
3 years, 9 months ago (2017-03-22 13:58:14 UTC) #3
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-22 13:58:30 UTC) #4
Bill Hesse
https://codereview.chromium.org/2768803002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/2768803002/diff/1/pkg/pkg.status#newcode16 pkg/pkg.status:16: analyzer/tool/summary/check_test: Skip # Issue 29133 On 2017/03/22 13:58:14, kustermann ...
3 years, 9 months ago (2017-03-22 14:02:49 UTC) #5
Bill Hesse
3 years, 9 months ago (2017-03-22 14:06:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0d65210256e7be80d44a46cdfebd90d842ceb6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698