Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/dev_compiler/web/stack_trace_mapper.dart

Issue 2768693003: fix errors and warnings in DDC (Closed)
Patch Set: update test expectation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/web/stack_trace_mapper.dart
diff --git a/pkg/dev_compiler/web/stack_trace_mapper.dart b/pkg/dev_compiler/web/stack_trace_mapper.dart
index fda5b8b95afea870f36807793389edabeef00e4e..c435f1d12b72ca984cb16bcfa38d71904b6bf805 100644
--- a/pkg/dev_compiler/web/stack_trace_mapper.dart
+++ b/pkg/dev_compiler/web/stack_trace_mapper.dart
@@ -22,9 +22,6 @@
@JS()
library stack_trace_mapper;
-import 'dart:async';
-import 'dart:html';
-
import 'package:js/js.dart';
import 'package:path/path.dart' as path;
import 'package:source_map_stack_trace/source_map_stack_trace.dart';
@@ -40,7 +37,7 @@ external set dartStackTraceUtility(DartStackTraceUtility value);
typedef String StackTraceMapper(String stackTrace);
typedef dynamic SourceMapProvider(String modulePath);
-typedef String SetSourceMapProvider(SourceMapProvider provider);
+typedef void SetSourceMapProvider(SourceMapProvider provider);
@JS()
@anonymous
@@ -96,17 +93,6 @@ class LazyMapping extends Mapping {
}
}
-String _toSourceMapLocation(String url) {
- // The url may have cache busting query parameters which we need to maintain
- // in the source map url.
- // For example:
- // http://localhost/foo.js?cachebusting=23419
- // Should get source map
- // http://localhost/foo.js.map?cachebusting=23419
- var uri = Uri.parse(url);
- return uri.replace(path: '${uri.path}.map').toString();
-}
-
LazyMapping _mapping;
String mapper(String rawStackTrace) {
@@ -118,7 +104,7 @@ String mapper(String rawStackTrace) {
return mapStackTrace(_mapping, new Trace.parse(rawStackTrace)).toString();
}
-void setSourceMapProvider(SourceMapProvider provider) async {
+void setSourceMapProvider(SourceMapProvider provider) {
_mapping = new LazyMapping(provider);
}
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698