Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 2768693003: fix errors and warnings in DDC (Closed)

Created:
3 years, 9 months ago by Jennifer Messerly
Modified:
3 years, 9 months ago
Reviewers:
vsm, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -42 lines) Patch
M pkg/dev_compiler/lib/src/compiler/ast_builder.dart View 2 chunks +0 lines, -21 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/web/stack_trace_mapper.dart View 4 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
Committed patchset #2 (id:20001) manually as 132ddcaacfa4f47df0e7656b6648cf5a11e181ba (presubmit successful).
3 years, 9 months ago (2017-03-22 03:12:13 UTC) #4
Jennifer Messerly
this (in theory) gets DDC's build green again.
3 years, 9 months ago (2017-03-22 03:12:29 UTC) #5
Jacob
3 years, 9 months ago (2017-03-22 03:18:08 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698