Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8928)

Unified Diff: chrome/browser/android/bookmarks/bookmark_bridge.cc

Issue 2768663002: [Bookmarks] Refactor search view to use SelectableListLayout paradigm (Closed)
Patch Set: Fix spelling error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/bookmark_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browser/android/bookmarks/bookmark_bridge.cc
index dab1632471ba080789edfa6c95d79ff6ed60df4a..c74859201385eaed1cdea78e7feef611ed1fa8f7 100644
--- a/chrome/browser/android/bookmarks/bookmark_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmark_bridge.cc
@@ -595,26 +595,8 @@ void BookmarkBridge::SearchBookmarks(JNIEnv* env,
for (const bookmarks::TitledUrlMatch& match : results) {
const BookmarkNode* node = static_cast<const BookmarkNode*>(match.node);
- std::vector<int> title_match_start_positions;
- std::vector<int> title_match_end_positions;
- for (auto position : match.title_match_positions) {
- title_match_start_positions.push_back(position.first);
- title_match_end_positions.push_back(position.second);
- }
-
- std::vector<int> url_match_start_positions;
- std::vector<int> url_match_end_positions;
- for (auto position : match.url_match_positions) {
- url_match_start_positions.push_back(position.first);
- url_match_end_positions.push_back(position.second);
- }
-
- Java_BookmarkBridge_addToBookmarkMatchList(
- env, j_list, node->id(), node->type(),
- ToJavaIntArray(env, title_match_start_positions),
- ToJavaIntArray(env, title_match_end_positions),
- ToJavaIntArray(env, url_match_start_positions),
- ToJavaIntArray(env, url_match_end_positions));
+ Java_BookmarkBridge_addToBookmarkIdList(env, j_list, node->id(),
+ node->type());
}
}
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698