Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2332)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

Issue 2768663002: [Bookmarks] Refactor search view to use SelectableListLayout paradigm (Closed)
Patch Set: Fix spelling error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
index d49f2c2e0fc567cc7f0079ddcab2e8300cff7e06..eadfccef18d8a44122be38ce79dcd14619ca7b30 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
@@ -190,10 +190,8 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
}
// TODO(twellington): remove this after the bookmarks 720dp layout is restyled
- // to match the < 720dp style and BookmarkSearchView is refactored.
- // Currently BookmarkSearchRow extends BookmarkRow but is not selectable.
- mShouldUseListItemBackground =
- isSelectable() && !DeviceFormFactor.isLargeTablet(getContext());
+ // to match the < 720dp style.
+ mShouldUseListItemBackground = !DeviceFormFactor.isLargeTablet(getContext());
// TODO(twellington): Replace this with a MarginResizer after the bookmarks layout is width
// constrained to 600dp.
@@ -263,8 +261,10 @@ abstract class BookmarkRow extends SelectableItemView<BookmarkId> implements Boo
}
@Override
- public void onFolderStateSet(BookmarkId folder) {
- }
+ public void onFolderStateSet(BookmarkId folder) {}
+
+ @Override
+ public void onSearchStateSet() {}
@Override
public void setBackgroundResourceForGroupPosition(

Powered by Google App Engine
This is Rietveld 408576698