Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java

Issue 2768663002: [Bookmarks] Refactor search view to use SelectableListLayout paradigm (Closed)
Patch Set: Fix spelling error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.bookmarks; 5 package org.chromium.chrome.browser.bookmarks;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.support.v7.widget.Toolbar.OnMenuItemClickListener; 8 import android.support.v7.widget.Toolbar.OnMenuItemClickListener;
9 import android.text.TextUtils; 9 import android.text.TextUtils;
10 import android.util.AttributeSet; 10 import android.util.AttributeSet;
(...skipping 29 matching lines...) Expand all
40 onSelectionStateChange(mDelegate.getSelectionDelegate().getSelectedI tems()); 40 onSelectionStateChange(mDelegate.getSelectionDelegate().getSelectedI tems());
41 } 41 }
42 }; 42 };
43 43
44 public BookmarkActionBar(Context context, AttributeSet attrs) { 44 public BookmarkActionBar(Context context, AttributeSet attrs) {
45 super(context, attrs); 45 super(context, attrs);
46 setNavigationOnClickListener(this); 46 setNavigationOnClickListener(this);
47 inflateMenu(R.menu.bookmark_action_bar_menu); 47 inflateMenu(R.menu.bookmark_action_bar_menu);
48 setOnMenuItemClickListener(this); 48 setOnMenuItemClickListener(this);
49 49
50 getMenu().findItem(R.id.search_menu_id).setTitle(R.string.bookmark_actio n_bar_search);
51 getMenu().findItem(R.id.selection_mode_edit_menu_id).setTitle(R.string.e dit_bookmark); 50 getMenu().findItem(R.id.selection_mode_edit_menu_id).setTitle(R.string.e dit_bookmark);
52 getMenu().findItem(R.id.selection_mode_move_menu_id) 51 getMenu().findItem(R.id.selection_mode_move_menu_id)
53 .setTitle(R.string.bookmark_action_bar_move); 52 .setTitle(R.string.bookmark_action_bar_move);
54 getMenu().findItem(R.id.selection_mode_delete_menu_id) 53 getMenu().findItem(R.id.selection_mode_delete_menu_id)
55 .setTitle(R.string.bookmark_action_bar_delete); 54 .setTitle(R.string.bookmark_action_bar_delete);
56 } 55 }
57 56
58 @Override 57 @Override
59 public void onNavigationBack() { 58 public void onNavigationBack() {
59 if (mIsSearching) {
60 super.onNavigationBack();
61 return;
62 }
63
60 mDelegate.openFolder(mCurrentFolder.getParentId()); 64 mDelegate.openFolder(mCurrentFolder.getParentId());
61 } 65 }
62 66
63 @Override 67 @Override
64 public boolean onMenuItemClick(MenuItem menuItem) { 68 public boolean onMenuItemClick(MenuItem menuItem) {
65 SelectionDelegate<BookmarkId> selectionDelegate = mDelegate.getSelection Delegate(); 69 SelectionDelegate<BookmarkId> selectionDelegate = mDelegate.getSelection Delegate();
66 if (menuItem.getItemId() == R.id.edit_menu_id) { 70 if (menuItem.getItemId() == R.id.edit_menu_id) {
67 BookmarkAddEditFolderActivity.startEditFolderActivity(getContext(), 71 BookmarkAddEditFolderActivity.startEditFolderActivity(getContext(),
68 mCurrentFolder.getId()); 72 mCurrentFolder.getId());
69 return true; 73 return true;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 setTitle(mCurrentFolder.getTitle()); 153 setTitle(mCurrentFolder.getTitle());
150 } 154 }
151 setNavigationButton(NAVIGATION_BUTTON_MENU); 155 setNavigationButton(NAVIGATION_BUTTON_MENU);
152 } else { 156 } else {
153 setTitle(mCurrentFolder.getTitle()); 157 setTitle(mCurrentFolder.getTitle());
154 setNavigationButton(NAVIGATION_BUTTON_BACK); 158 setNavigationButton(NAVIGATION_BUTTON_BACK);
155 } 159 }
156 } 160 }
157 161
158 @Override 162 @Override
163 public void onSearchStateSet() {}
164
165 @Override
159 public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) { 166 public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) {
160 super.onSelectionStateChange(selectedBookmarks); 167 super.onSelectionStateChange(selectedBookmarks);
161 168
162 // The super class registers itself as a SelectionObserver before 169 // The super class registers itself as a SelectionObserver before
163 // #onBookmarkDelegateInitialized() is called. Return early if mDelegate has not been set. 170 // #onBookmarkDelegateInitialized() is called. Return early if mDelegate has not been set.
164 if (mDelegate == null) return; 171 if (mDelegate == null) return;
165 172
166 if (mIsSelectionEnabled) { 173 if (mIsSelectionEnabled) {
167 // Editing a bookmark action on multiple selected items doesn't make sense. So disable. 174 // Editing a bookmark action on multiple selected items doesn't make sense. So disable.
168 getMenu().findItem(R.id.selection_mode_edit_menu_id).setVisible( 175 getMenu().findItem(R.id.selection_mode_edit_menu_id).setVisible(
(...skipping 23 matching lines...) Expand all
192 } 199 }
193 200
194 private static void openBookmarksInNewTabs( 201 private static void openBookmarksInNewTabs(
195 List<BookmarkId> bookmarks, TabDelegate tabDelegate, BookmarkModel m odel) { 202 List<BookmarkId> bookmarks, TabDelegate tabDelegate, BookmarkModel m odel) {
196 for (BookmarkId id : bookmarks) { 203 for (BookmarkId id : bookmarks) {
197 tabDelegate.createNewTab(new LoadUrlParams(model.getBookmarkById(id) .getUrl()), 204 tabDelegate.createNewTab(new LoadUrlParams(model.getBookmarkById(id) .getUrl()),
198 TabLaunchType.FROM_LONGPRESS_BACKGROUND, null); 205 TabLaunchType.FROM_LONGPRESS_BACKGROUND, null);
199 } 206 }
200 } 207 }
201 } 208 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698