chrome/browser/ui/toolbar/app_menu_model.cc - Issue 2768633003: Dynamic updating recent menu for tabs from other devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.cc

Issue 2768633003: Dynamic updating recent menu for tabs from other devices. (Closed)

Patch Set: Fixes after review. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/app_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc

index 7c6bd9250cb1d280b38cff0b57b0eccffad3279a..c55050d2c8ff83f91d00c544fd1fd283225c0e26 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.cc

+++ b/chrome/browser/ui/toolbar/app_menu_model.cc

@@ -717,9 +717,8 @@ void AppMenuModel::Build() {

AddSeparator(ui::NORMAL_SEPARATOR);

if (!browser_->profile()->IsOffTheRecord()) {

- recent_tabs_sub_menu_model_.reset(new RecentTabsSubMenuModel(provider_,

- browser_,

- NULL));

+ recent_tabs_sub_menu_model_ =

+ base::MakeUnique<RecentTabsSubMenuModel>(provider_, browser_);

AddSubMenuWithStringId(IDC_RECENT_TABS_MENU, IDS_HISTORY_MENU,

recent_tabs_sub_menu_model_.get());

}