Dynamic updating recent menu for tabs from other devices.

components/browser_sync/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define COMPONENTS_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 40 matching lines @@
 #include "components/sync/model/model_type_store.h"
 #include "components/sync/syncable/user_share.h"
 #include "components/version_info/version_info.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "google_apis/gaia/oauth2_token_service.h"
 #include "net/base/backoff_entry.h"
 #include "url/gurl.h"
 
 class Profile;
 class ProfileOAuth2TokenService;
+class RecentTabsSubMenuModelTest;
 class SigninManagerWrapper;
 
 namespace sync_sessions {
 class FaviconCache;
 class OpenTabsUIDelegate;
 class SessionsSyncManager;
 }  // namespace sync_sessions
 
 namespace syncer {
 class BackendMigrator;
@@ skipping 534 matching lines @@
     NOT_REQUESTED,            // The user turned off sync.
     NOT_REQUESTED_NOT_SETUP,  // The user turned off sync and setup completed
                               // is false. Might indicate a stop-and-clear.
     NEEDS_CONFIRMATION,       // The user must confirm sync settings.
     IS_MANAGED,               // Sync is disallowed by enterprise policy.
     NOT_ALLOWED_BY_PLATFORM,  // Sync is disallowed by the platform.
     SYNC_INITIAL_STATE_LIMIT
   };
 
   friend class TestProfileSyncService;
+  friend class ::RecentTabsSubMenuModelTest;

[Peter Kasting, 2017/03/23 04:48:35]

Is there a way to test this functionality without using private APIs?  If not,
I'm inclined to suggest refactoring so there is.  I'm uncomfortable with a
random toolbar test needing to reach into the internals of a sync class.

For example, make the recent tabs submenu model have a mockable or injectable
data source, so it doesn't need to talk to sync at all in test code.

 
   // Helper to install and configure a data type manager.
   void ConfigureDataTypeManager();
 
   // Shuts down the engine sync components.
   // |reason| dictates if syncing is being disabled or not, and whether
   // to claim ownership of sync thread from engine.
   void ShutdownImpl(syncer::ShutdownReason reason);
 
   // Helper method for managing encryption UI.
@@ skipping 263 matching lines @@
   base::WeakPtrFactory<ProfileSyncService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(const syncer::SyncProtocolError& error);
 
 }  // namespace browser_sync
 
 #endif  // COMPONENTS_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_