chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_not_registered_on_daydream.html - Issue 2768583002: Make VR screen tap tests more stable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_not_registered_on_daydream.html

Issue 2768583002: Make VR screen tap tests more stable (Closed)

Patch Set: Move VR test library behind flag Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <!--	2 <!--

3 Tests that screen taps aren't registered while in VR when viewer is	3 Tests that screen taps aren't registered while in VR when viewer is

4 Daydream View	4 Daydream View

5 -->	5 -->

6 <html>	6 <html>

7 <head>	7 <head>

8 <link rel="stylesheet" type="text/css" href="../resources/webvr_e2e.css">	8 <link rel="stylesheet" type="text/css" href="../resources/webvr_e2e.css">

9 </head>	9 </head>

10 <body>	10 <body>

(...skipping 12 matching lines...) Expand all Loading...
23 t.step( () => {	23 t.step( () => {

24 assert_equals(numTaps, 0, "No initial taps");	24 assert_equals(numTaps, 0, "No initial taps");

25 });	25 });

26 finishJavascriptStep();	26 finishJavascriptStep();

27 }	27 }

28	28

29 function stepVerifyNoAdditionalTaps() {	29 function stepVerifyNoAdditionalTaps() {

30 t.step_func_done( () => {	30 t.step_func_done( () => {

31 // We expect 1 tap from entering VR	31 // We expect 1 tap from entering VR

32 assert_equals(numTaps, 1,	32 assert_equals(numTaps, 1,

33 "Only tap one tap registered after two taps given");	33 "Only one tap registered after two taps given");

34 })();	34 })();

35 }	35 }

36	36

37 </script>	37 </script>

38 </body>	38 </body>

39 </html>	39 </html>

OLD	NEW