Send traffic-management headers from extension updater.

extensions/browser/updater/manifest_fetch_data.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/updater/manifest_fetch_data.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 23 matching lines @@
     }
   }
 }
 
 }  // namespace
 
 ManifestFetchData::ManifestFetchData(const GURL& update_url,
                                      int request_id,
                                      const std::string& brand_code,
                                      const std::string& base_query_params,
-                                     PingMode ping_mode)
+                                     PingMode ping_mode,
+                                     bool foreground_check)
     : base_url_(update_url),
       full_url_(update_url),
       brand_code_(brand_code),
-      ping_mode_(ping_mode) {
+      ping_mode_(ping_mode),
+      foreground_check_(foreground_check) {
   std::string query =
       full_url_.has_query() ? full_url_.query() + "&" : std::string();
   query += base_query_params;
   GURL::Replacements replacements;
   replacements.SetQueryStr(query);
   full_url_ = full_url_.ReplaceComponents(replacements);
 
   request_ids_.insert(request_id);
 }
 
@@ skipping 19 matching lines @@
 //   Extension 2- id:bbbb version:2.0
 //
 // the full update url would be:
 //   http://somehost/path?x=id%3Daaaa%26v%3D1.1%26uc&x=id%3Dbbbb%26v%3D2.0%26uc
 //
 // (Note that '=' is %3D and '&' is %26 when urlencoded.)
 bool ManifestFetchData::AddExtension(const std::string& id,
                                      const std::string& version,
                                      const PingData* ping_data,
                                      const std::string& update_url_data,
-                                     const std::string& install_source) {
+                                     const std::string& install_source,
+                                     bool foreground_check) {
   if (extension_ids_.find(id) != extension_ids_.end()) {
     NOTREACHED() << "Duplicate extension id " << id;
     return false;
   }
 
+  if (foreground_check != foreground_check_) {
+    return false;

[Devlin, 2017/03/24 15:14:47]

It's a little worrisome to me that we just silently abort here.  I would expect
either:
a) We do foreground_check_ |= foreground_check (similar to Merge())
b) We CHECK and enforce this never happens

Of the two, a) seems perhaps more reasonable, since otherwise trying to add an
Extension with a conflicting foreground value to an existing ManifestFetchData
would fail, but creating a new ManifestFetchData and merging them would succeed.

[Minh X. Nguyen, 2017/03/27 23:05:29]

Done.

+  }
+
   // Compute the string we'd append onto the full_url_, and see if it fits.
   std::vector<std::string> parts;
   parts.push_back("id=" + id);
   parts.push_back("v=" + version);
   if (!install_source.empty())
     parts.push_back("installsource=" + install_source);
   parts.push_back("uc");
 
   if (!update_url_data.empty()) {
     // Make sure the update_url_data string is escaped before using it so that
@@ skipping 62 matching lines @@
     value = i->second.rollcall_days;
   else if (type == ACTIVE)
     value = i->second.active_days;
   else
     NOTREACHED();
   return value == kNeverPinged || value > 0;
 }
 
 void ManifestFetchData::Merge(const ManifestFetchData& other) {
   DCHECK(full_url() == other.full_url());
+  foreground_check_ |= other.foreground_check_;

[Devlin, 2017/03/24 15:14:47]

can we add/modify a unittest for this?

[Minh X. Nguyen, 2017/03/27 23:05:29]

Done.

   request_ids_.insert(other.request_ids_.begin(), other.request_ids_.end());
 }
 
 }  // namespace extensions